Skip to content

chore(website): make playground code editor horizontally resizable #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 24, 2022
Merged

chore(website): make playground code editor horizontally resizable #5667

merged 7 commits into from
Sep 24, 2022

Conversation

yimothysu
Copy link
Contributor

@yimothysu yimothysu commented Sep 17, 2022 •
edited
Loading

PR Checklist

Overview

Adds horizontal resizing functionality via dragging for the code editor in the website Playground.
Clipboard01

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @jimsu2012!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 17, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 643b5b0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Sep 17, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 643b5b0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/632e2272f24d9b00088b717a
😎 Deploy Preview https://deploy-preview-5667--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yimothysu yimothysu changed the title Make editor horizontally resizable feat(website): make playground code editor horizontally resizable Sep 17, 2022
@bradzacher bradzacher changed the title feat(website): make playground code editor horizontally resizable chore(website): make playground code editor horizontally resizable Sep 17, 2022
JoshuaKGoldberg
JoshuaKGoldberg previously requested changes Sep 17, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great start! 🚀

@JoshuaKGoldberg JoshuaKGoldberg dismissed their stale review September 19, 2022 00:52

Updated since the review

@yimothysu
Copy link
Contributor Author

The websites tests failing is unrelated to this change. The latest commit to main (78467fc) has the same error.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Sep 20, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks! ✨

Just a couple bugs to fix up. Using a ResizeObserver or similar would be swell but I'm fine to just file that as a cleanup for later.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 20, 2022
@yimothysu yimothysu dismissed a stale review via 95d27d7 September 21, 2022 00:36
JoshuaKGoldberg
JoshuaKGoldberg requested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks so much for sending this in & iterating on it @jimsu2012! 🙌

Just a couple of code reuse requests. I can tackle them myself if you don't have the time - lmk!

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

@JoshuaKGoldberg JoshuaKGoldberg merged commit b8e56a6 into typescript-eslint:main Sep 24, 2022
@yimothysu
Copy link
Contributor Author

Awesome, excited to see this in prod!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party website: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Allow resizing/collapsing panes
3 participants
@yimothysu @JoshuaKGoldberg @bradzacher