chore: document and refactor 'extra' to 'parserSettings' #5834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
8e502de to
3ead14e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5834 +/- ##
==========================================
+ Coverage 91.33% 91.36% +0.03%
==========================================
Files 361 364 +3
Lines 12044 12134 +90
Branches 3506 3540 +34
==========================================
+ Hits 11000 11086 +86
Misses 748 748
- Partials 296 300 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bradzacher
reviewed
Oct 24, 2022
packages/typescript-estree/src/create-program/createSourceFile.ts
Outdated
Show resolved
Hide resolved
😭 Edit: went away on re-run. I'm going to pretend this little blip never happened. |
bradzacher
previously approved these changes
Oct 24, 2022
packages/typescript-estree/src/parseSettings/createParseSettings.ts
Outdated
Show resolved
Hide resolved
…gs.ts Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
…xtra-to-parser-settings
JoshuaKGoldberg
commented
Oct 25, 2022
|
Getting real tired of having to re-request review after merges 🥲 |
bradzacher
approved these changes
Oct 25, 2022
JoshuaKGoldberg
added a commit
that referenced
this pull request
Oct 25, 2022
) * refactor(utils)!: removed `TRuleListener` generic from the `createRule` * refactor!: removed `TRuleListener` generic from the `CLIEngine` and `RuleCreateFunction` * chore: document and refactor 'extra' to 'parserSettings' (#5834) * chore(website): fix renamed Sponsorship docs link (#5882) * docs: Mention wide globs performance implications in monorepos docs and parser README (#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
JoshuaKGoldberg
added a commit
that referenced
this pull request
Oct 26, 2022
* feat: update TSImportType node * fix: update visitor keys * chore: document and refactor 'extra' to 'parserSettings' (#5834) * chore(website): fix renamed Sponsorship docs link (#5882) * docs: Mention wide globs performance implications in monorepos docs and parser README (#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
JoshuaKGoldberg
added a commit
that referenced
this pull request
Oct 26, 2022
* feat(scope-manager): ignore ECMA version * chore: document and refactor 'extra' to 'parserSettings' (#5834) * chore(website): fix renamed Sponsorship docs link (#5882) * Remove much more * Fix WebLinter lint * docs: Mention wide globs performance implications in monorepos docs and parser README (#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> * chore: add auto-canary release for v6 (#5883) Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
codeandextravariables #5833Overview
Despite the nontrivial diff, this shouldn't change any significant logic.
ast,code,extra, andprogrammodule scoped variables into parameters that get passed aroundextraExtratoParseSettingsand adds doc comments for its propertiesparserSettings(formerlyextra) into acreateParseSettingsfunction, and makes it almost all happen in-placeI'm choosing to ignore the Codecov complaint because the diff is reducing lines of code ✨. But if you think we should test these edge cases more, I could use some help figuring out where that should go.