chore: v6.0.0 #5886

JoshuaKGoldberg · 2022-10-26T00:43:20Z

BREAKING CHANGE: v6, hooray! 🥳

This PR contains all of the changes for v6.0.0.
We will ~~rebase~~ merge this onto main

typescript-eslint · 2022-10-26T00:43:21Z

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

nx-cloud · 2022-10-26T00:43:22Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f0f45a9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 51 targets

Sent with 💌 from NxCloud.

netlify · 2022-10-26T00:43:24Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`3201f78`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64ac4142c9eaa20007c5f8f3
😎 Deploy Preview	https://deploy-preview-5886--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

package.json

bmish · 2022-11-11T00:26:55Z

Is it time to drop ESLint v6 support from peer deps? It was released in 2019: https://eslint.org/blog/2019/06/eslint-v6.0.0-released/

"peerDependencies": {
  "eslint": "^6.0.0 || ^7.0.0 || ^8.0.0"
},

bmish · 2022-11-11T00:29:49Z

What do you think of strictly-defining the Node API with exports in each package?

This would follow the lead of ESLint core and other ESLint plugins so that users cannot reach in and import/depend on arbitrary files inside the package.

https://eslint.org/docs/latest/user-guide/migrating-to-8.0.0#remove-lib

Beginning in v8.0.0, ESLint is strictly defining its public API. Previously, you could reach into individual files such as require("eslint/lib/rules/semi") and this is no longer allowed. There are a limited number of existing APIs that are now available through the /use-at-your-own-risk entrypoint for backwards compatibility, but these APIs are not formally supported and may break or disappear at any point in time.

https://nodejs.org/api/packages.html#main-entry-point-export

bradzacher · 2022-11-11T00:45:10Z

What do you think of strictly-defining the Node API with exports in each package?

We're all for it - #5586

bradzacher · 2022-11-11T00:45:52Z

Is it time to drop ESLint v6 support from peer deps?

Sounds good to me! Last major we dropped v5 support - so happy to do it.
Filed #5968 to track

bmish · 2022-11-11T00:51:24Z

In case you guys aren't already tracking it, I see a lot of "TODO" / @deprecated / deprecated comments throughout the codebase mentioning breaking changes that would be good to make now.

bmish · 2022-11-11T01:00:49Z

I also see 5 deprecated rules that could be deleted.

JoshuaKGoldberg · 2022-11-11T15:00:48Z

@bmish thanks for pointing these out! Anything that we've marked as deprecated (should be removed in general) deserves an issue tracking it. If you see anything that doesn't yet have one, feel free to file it!

I want to eventually do a sweep but haven't had the time. 🥲

) * refactor(utils)!: removed `TRuleListener` generic from the `createRule` * refactor!: removed `TRuleListener` generic from the `CLIEngine` and `RuleCreateFunction` * chore: document and refactor 'extra' to 'parserSettings' (#5834) * chore(website): fix renamed Sponsorship docs link (#5882) * docs: Mention wide globs performance implications in monorepos docs and parser README (#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>

* feat: update TSImportType node * fix: update visitor keys * chore: document and refactor 'extra' to 'parserSettings' (#5834) * chore(website): fix renamed Sponsorship docs link (#5882) * docs: Mention wide globs performance implications in monorepos docs and parser README (#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>

* feat(scope-manager): ignore ECMA version * chore: document and refactor 'extra' to 'parserSettings' (#5834) * chore(website): fix renamed Sponsorship docs link (#5882) * Remove much more * Fix WebLinter lint * docs: Mention wide globs performance implications in monorepos docs and parser README (#5864) * docs: Mention wide globs performance implications in monorepos docs and parser readme * Update docs/linting/typed-linting/MONOREPOS.md Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com> * chore: add auto-canary release for v6 (#5883) Co-authored-by: Adnan Hashmi <56730784+adnanhashmi09@users.noreply.github.com>

…TSInterfaceDeclaration and TSModuleDeclaration (#4863) * chore: remove invalid properties from ast nodes * chore: remove invalid code in scope-manager and typescript-estree * chore: re-write snapshots that were using invalid properties * feat: remove modifiers union from ast types Co-authored-by: Juan García <juank1809@gmail.com> Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

…#5381)

* feat(eslint-plugin): apply final v6 changes to configs * Ah, fixed new lint rule violations internally * no-mixed-enums strict * Apply suggestions from code review Co-authored-by: Brad Zacher <brad.zacher@gmail.com> * Fix up build & lint issues * Never mind, prefer nullish coalescing --------- Co-authored-by: Brad Zacher <brad.zacher@gmail.com>

* chore: enabled stylistic-type-checked internally * Reduced scope of changes * Updated snapshots * Update packages/typescript-estree/tests/lib/convert.test.ts Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com> * More deeplyCopy removals * Updated test snapshots --------- Co-authored-by: rubiesonthesky <2591240+rubiesonthesky@users.noreply.github.com>

* feat(eslint-plugin): final final config changes for v6 * yarn generate:configs * Fix unused lint suppression complaint and test snapshot * unknown, not any, in recommended-does-not-require-program * Updated endColumn

JoshuaKGoldberg · 2023-07-04T23:26:08Z

~~Ran into some gnarly merge conflicts. Fixed most of them but ran out of time for the rest. Will finish soon.~~ ✅

…irst operands are unrelated to the rest of the chain and add type info (#6397)

…ver match error types (#6869) * fix(type-utils): treat intrinsic types as if they are from lib and never match error types * Update packages/type-utils/tests/TypeOrValueSpecifier.test.ts * chore: bump ts-api-utils to 1.0.1 * refactor: use isIntrinsicErrorType --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

JoshuaKGoldberg added this to the 6.0.0 milestone Oct 26, 2022

bmish reviewed Nov 11, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

bmish mentioned this pull request Nov 11, 2022

feat: drop support for node v12 #5918

Merged

3 tasks

bradzacher mentioned this pull request Nov 11, 2022

Drop support for NodeJS v12 #5917

Closed

This was referenced Nov 13, 2022

Repo: Raise tsconfig target #5980

Closed

chore: raise tsconfig target to ES2021 #5981

Merged

chore: drop support for ESLint v6 #5972

Merged

Andarist and others added 5 commits November 23, 2022 16:40

fix(eslint-plugin): remove valid-typeof disable in eslint-recommended (…

b82df5e

…#5381)

JoshuaKGoldberg and others added 11 commits June 18, 2023 09:25

build: add publishConfig.access = 'public' to rule-tester/package.json

b411706

docs: remove erroneous hasFullTypeInformation .mdx reference

36b65eb

Merge branch 'main' into v6

371fc26

docs: fix broken links v6 docs (#7082)

5ea887d

feat(typescript-estree): remove parseWithNodeMaps (#7120)

e2a0a76

chore: enable sort-type-constituents internally (#7028)

3cdf5c9

feat(eslint-plugin): final final config changes for v6 (#7157)

e35c5c1

* feat(eslint-plugin): final final config changes for v6 * yarn generate:configs * Fix unused lint suppression complaint and test snapshot * unknown, not any, in recommended-does-not-require-program * Updated endColumn

Merge branch 'main'

c233652

Fix react-split-pane patching

e99f3b3

JoshuaKGoldberg and others added 8 commits July 6, 2023 15:41

Remove unnecessary test log

0f807ed

Touch up JSXNamespacedName component-dashed fixture to align to docs

6c99c3b

Included basic for reference too

aaf0cb5

ts-expect-error for #7166

41d68ea

Updated test snapshots

ca3fc02

feat(eslint-plugin): [prefer-optional-chain] handle cases where the f…

02a37c4

…irst operands are unrelated to the rest of the chain and add type info (#6397)

chore: updated v6 blog post for new 'final final' configs

c8bb00d

JoshuaKGoldberg mentioned this pull request Jul 7, 2023

Website: codeblock comments and unchanged diff lines don't have enough contrast #7171

Closed

2 tasks

JoshuaKGoldberg marked this pull request as ready for review July 7, 2023 16:24

JoshuaKGoldberg added 5 commits July 10, 2023 13:11

Merge branch 'main'

bccf851

Reset prefer-nullish-coalescing.test.ts to main

d2104ae

Merge branch 'main' (I swear this had better be the last one

980bda3

Fix: yarn generate-configs

64958d3

Fix prefer-nullish-coalescing too

3201f78

JoshuaKGoldberg merged commit ca1abb5 into main Jul 10, 2023

JoshuaKGoldberg deleted the v6 branch July 10, 2023 17:52

github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: v6.0.0 #5886

chore: v6.0.0 #5886

JoshuaKGoldberg commented Oct 26, 2022 •

edited

Loading

typescript-eslint bot commented Oct 26, 2022

nx-cloud bot commented Oct 26, 2022 •

edited

Loading

netlify bot commented Oct 26, 2022 •

edited

Loading

bmish commented Nov 11, 2022

bmish commented Nov 11, 2022

bradzacher commented Nov 11, 2022

bradzacher commented Nov 11, 2022

bmish commented Nov 11, 2022 •

edited

Loading

bmish commented Nov 11, 2022

JoshuaKGoldberg commented Nov 11, 2022

JoshuaKGoldberg commented Jul 4, 2023 •

edited

Loading

chore: v6.0.0 #5886

chore: v6.0.0 #5886

Conversation

JoshuaKGoldberg commented Oct 26, 2022 • edited Loading

typescript-eslint bot commented Oct 26, 2022

nx-cloud bot commented Oct 26, 2022 • edited Loading

☁️ Nx Cloud Report

netlify bot commented Oct 26, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

bmish commented Nov 11, 2022

bmish commented Nov 11, 2022

bradzacher commented Nov 11, 2022

bradzacher commented Nov 11, 2022

bmish commented Nov 11, 2022 • edited Loading

bmish commented Nov 11, 2022

JoshuaKGoldberg commented Nov 11, 2022

JoshuaKGoldberg commented Jul 4, 2023 • edited Loading

JoshuaKGoldberg commented Oct 26, 2022 •

edited

Loading

nx-cloud bot commented Oct 26, 2022 •

edited

Loading

netlify bot commented Oct 26, 2022 •

edited

Loading

bmish commented Nov 11, 2022 •

edited

Loading

JoshuaKGoldberg commented Jul 4, 2023 •

edited

Loading