Skip to content

chore: removed eslint@6 fallbacks for rule messages, and a snapshot #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2022
Merged

chore: removed eslint@6 fallbacks for rule messages, and a snapshot #6041

merged 1 commit into from
Nov 19, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 19, 2022 •
edited
Loading

Overview

I stumbled onto some more references to ESLint v6 in the codebase. I hadn't known about them. 🔪

cc @bmish from #5968 -> #5972

@nx-cloud
Copy link

nx-cloud bot commented Nov 19, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ca41067. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to v6 November 19, 2022 06:35
@netlify
Copy link

netlify bot commented Nov 19, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ef4465f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6378791c9ba9640009badd16
😎 Deploy Preview https://deploy-preview-6041--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 19, 2022 06:38
@codecov
Copy link

codecov bot commented Nov 19, 2022 •
edited
Loading

Codecov Report

Merging #6041 (ca41067) into v6 (b8c65fd) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##               v6    #6041      +/-   ##
==========================================
+ Coverage   91.69%   91.72%   +0.02%     
==========================================
  Files         356      356              
  Lines       12023    12018       -5     
  Branches     3524     3519       -5     
==========================================
- Hits        11024    11023       -1     
  Misses        701      701              
+ Partials      298      294       -4
Flag Coverage Δ
unittest 91.72% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-invalid-this.ts 83.33% <ø> (+3.33%) ⬆️
...s/eslint-plugin/src/rules/no-unused-expressions.ts 94.44% <ø> (+4.97%) ⬆️
.../eslint-plugin/src/rules/no-useless-constructor.ts 94.73% <0.00%> (-0.27%) ⬇️
packages/eslint-plugin/src/rules/quotes.ts 94.11% <ø> (+5.22%) ⬆️
packages/eslint-plugin/src/rules/semi.ts 100.00% <ø> (+7.14%) ⬆️

@JoshuaKGoldberg JoshuaKGoldberg merged commit e649ea0 into typescript-eslint:v6 Nov 19, 2022
@bmish
Copy link
Contributor

bmish commented Nov 19, 2022

Good catch.

@JoshuaKGoldberg JoshuaKGoldberg deleted the more-eslint-removals branch November 19, 2022 16:57
bradzacher pushed a commit that referenced this pull request Nov 23, 2022
@JoshuaKGoldberg @bradzacher
chore: removed eslint@6 fallbacks for rule messages, and a snapshot (#…
36dc7ce 
…6041)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaKGoldberg @bmish @bradzacher