Skip to content

test(website): add Playwright test for Playground linting #6080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2022
Merged

test(website): add Playwright test for Playground linting #6080

merged 2 commits into from
Nov 25, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 24, 2022 •
edited
Loading

PR Checklist

Overview

Adds a playground test that:

  1. Types passing code & enables a rule with no issues
  2. Changes the code to fail the rule
  3. Autofixes the code to pass again

Also fixes an accessibility oddity with labels in the visual dropdown for rules. There's no space between rule name and description currently:

await page
  .getByLabel(
-    '@typescript-eslint/array-typeRequire consistently using either `T[]` or `Array<T>` for arrays',
+    '@typescript-eslint/array-type Require consistently using either `T[]` or `Array<T>` for arrays',
  )
  .check();

@nx-cloud
Copy link

nx-cloud bot commented Nov 24, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab2189b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 24, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ab2189b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/637fa844eb445d000823f82c
😎 Deploy Preview https://deploy-preview-6080--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JoshuaKGoldberg
JoshuaKGoldberg commented Nov 24, 2022
View reviewed changes
packages/website/playwright.config.ts
@@ -22,6 +23,7 @@ const config: PlaywrightTestConfig = {
webServer: {
command: 'yarn start',
port: 3000,
reuseExistingServer: !process.env.CI,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly necessary for this PR, but really nice when working locally 😄.

https://playwright.dev/docs/test-advanced#launching-a-development-web-server-during-the-tests

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 24, 2022 17:21
bradzacher
bradzacher approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

genius-gif

@bradzacher bradzacher merged commit 87a2736 into typescript-eslint:main Nov 25, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the e2e-playground-usage branch November 25, 2022 06:43
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 25, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: add e2e test(s) for the website playground
2 participants
@JoshuaKGoldberg @bradzacher