Skip to content

test(website): add AST viewer test case #6275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 5, 2023
Merged

test(website): add AST viewer test case #6275

merged 6 commits into from
Apr 5, 2023

Conversation

tapanprakasht
Copy link
Contributor

PR Checklist

Overview

Added AST viewer playwright test case.

@nx-cloud
Copy link

nx-cloud bot commented Dec 25, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 29021a7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @tapanprakasht!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 25, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9a3276d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/642d87ab072a3000084a2713
😎 Deploy Preview https://deploy-preview-6275--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tapanprakasht tapanprakasht changed the title test(website): Add AST viewer test case test(website): add AST viewer test case Dec 25, 2022
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, thanks @tapanprakasht! This is great.

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) December 26, 2022 17:00
@tapanprakasht
Copy link
Contributor Author

tapanprakasht commented Dec 26, 2022 •
edited
Loading

@JoshuaKGoldberg Thanks for checking the PR. I do face some challenges here for the test case. writeInEditor doesn't seems to be behaving as expected. I see typed text in the editor disappear automatically while running the test case which is causing the test to fail. I see the same behavior in the previous test case Usage while running locally. Later typed text is retained in the editor. Do you face the same challenge running the test cases?

JoshuaKGoldberg
JoshuaKGoldberg requested changes Dec 30, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun!

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Dec 30, 2022
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 19, 2023
@bradzacher bradzacher added the tests anything to do with testing label Jan 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-requested a review February 19, 2023 04:34
@JoshuaKGoldberg
Copy link
Member

Oh hey thanks for the reminder armano2 - ping @tapanprakasht, if you merge the latest main into this branch I think you should be unblocked. Is there anything you're waiting for our input on?

@nx-cloud
Copy link

nx-cloud bot commented Apr 5, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9a3276d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@tapanprakasht
Copy link
Contributor Author

Oh hey thanks for the reminder armano2 - ping @tapanprakasht, if you merge the latest main into this branch I think you should be unblocked. Is there anything you're waiting for our input on?

@JoshuaKGoldberg Updated the test cases on top the latest master branch

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, looks like all is passing! Thanks @tapanprakasht - this is great. Sorry it took so long to get it approved!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 75806c9 into typescript-eslint:main Apr 5, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Apr 5, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Add an end-to-end (Playwright) test for the playground's AST viewer
4 participants
@tapanprakasht @JoshuaKGoldberg @armano2 @bradzacher