feat(eslint-plugin): [no-floating-promises] error on logical expression #6356

islandryu · 2023-01-20T00:31:54Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-floating-promises] Not marking as error when combined with a logical operator variable #6343
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Promise in logical expression now also throws an error.

typescript-eslint · 2023-01-20T00:31:55Z

Thanks for the PR, @islandryu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

nx-cloud · 2023-01-20T00:31:56Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab1bf4c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

netlify · 2023-01-20T00:32:01Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`ab1bf4c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63dd15106ad3d1000815ce46
😎 Deploy Preview	https://deploy-preview-6356--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

islandryu · 2023-01-20T00:39:06Z

packages/eslint-plugin/tests/rules/no-floating-promises.test.ts

+  const myPromise = async () => void 0;
+  const condition = true;
+
+  void (condition && myPromise());


The entire logical expression is enclosed in parentheses as in return-await.
https://typescript-eslint.io/play/#ts=4.9.3&sourceType=module&code=IYZwngdgxgBAZgV2gFwJYHsIwEbAE4AUAlDAN4wC+AsAFCiSyIoZZzrrFm0wzJ5hcaPHngCmyBHixIAJqLioIomTAA+qnPmIBubpRhRgyKAAsylWhSA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6aRfWaJ2gQwDufSvnRRE0aAHtokcGAC+IBUA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA

JoshuaKGoldberg

LGTM, thanks! Just fix the build failure and 🚀 let's ship.

I was on the fence as to whether the suggestions should put the await/void immediately in front of the specific promise, rather than outside the logical expression (i.e. a || (await b) rather than await (a || b). But since it's just suggestions, not auto-fixing, I think this is fine to keep the rule simpler.

packages/eslint-plugin/src/rules/no-floating-promises.ts

…t-eslint into featNoFloatingPromisesLogicalExpressions

codecov · 2023-02-03T07:58:13Z

Codecov Report

Merging #6356 (ab1bf4c) into main (fc24a57) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6356   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         371      371           
  Lines       12649    12651    +2     
  Branches     3714     3717    +3     
=======================================
+ Hits        11577    11579    +2     
+ Misses        755      754    -1     
- Partials      317      318    +1

Flag	Coverage Δ
unittest	`91.52% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts	`100.00% <100.00%> (ø)`
...es/eslint-plugin/src/util/getOperatorPrecedence.ts	`42.85% <0.00%> (ø)`

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

islandryu · 2023-02-03T08:56:17Z

Build is cured!

JoshuaKGoldberg

One teeeeny thing

packages/eslint-plugin/src/rules/no-floating-promises.ts

JoshuaKGoldberg

🔥

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.50.0` -> `5.51.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.50.0/5.51.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.50.0` -> `5.51.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.50.0/5.51.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.51.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5510-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5500v5510-2023-02-06) [Compare Source](typescript-eslint/typescript-eslint@v5.50.0...v5.51.0) ##### Bug Fixes - **eslint-plugin:** \[sort-type-constituents] fixed behavior change ([#6384](typescript-eslint/typescript-eslint#6384)) ([5bf7f7f](typescript-eslint/typescript-eslint@5bf7f7f)), closes [#6339](typescript-eslint/typescript-eslint#6339) - **eslint-plugin:** do not use .at(), Node 14 does not support it ([#6402](typescript-eslint/typescript-eslint#6402)) ([077ed1b](typescript-eslint/typescript-eslint@077ed1b)) ##### Features - **eslint-plugin:** \[naming-convention] improve performance by removing unnecessary selectors ([#6376](typescript-eslint/typescript-eslint#6376)) ([3647a1c](typescript-eslint/typescript-eslint@3647a1c)) - **eslint-plugin:** \[no-floating-promises] error on logical expression ([#6356](typescript-eslint/typescript-eslint#6356)) ([f330e06](typescript-eslint/typescript-eslint@f330e06)) - **eslint-plugin:** \[no-import-type-side-effects] add rule to warn against runtime side effects with `verbatimModuleSyntax` ([#6394](typescript-eslint/typescript-eslint#6394)) ([b14d3be](typescript-eslint/typescript-eslint@b14d3be)) - **eslint-plugin:** \[strict-boolean-expressions] add allow nullable enum to strict boolean expressions ([#6096](typescript-eslint/typescript-eslint#6096)) ([d4747cd](typescript-eslint/typescript-eslint@d4747cd)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.51.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5510-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5500v5510-2023-02-06) [Compare Source](typescript-eslint/typescript-eslint@v5.50.0...v5.51.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1773 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

feat(eslint-plugin) [no-floating-promises] Error on logical expression

7c3f94e

islandryu commented Jan 20, 2023

View reviewed changes

islandryu changed the title ~~feat(eslint-plugin) [no-floating-promises] Error on logical expression~~ feat(eslint-plugin): [no-floating-promises] Error on logical expression Jan 20, 2023

islandryu changed the title ~~feat(eslint-plugin): [no-floating-promises] Error on logical expression~~ feat(eslint-plugin): [no-floating-promises] error on logical expression Jan 20, 2023

bradzacher added the enhancement New feature or request label Jan 30, 2023

JoshuaKGoldberg previously approved these changes Jan 31, 2023

View reviewed changes

packages/eslint-plugin/src/rules/no-floating-promises.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 31, 2023

bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Feb 2, 2023

Merge branch 'main' of https://github.com/typescript-eslint/typescrip…

7abf0af

…t-eslint into featNoFloatingPromisesLogicalExpressions

islandryu dismissed JoshuaKGoldberg’s stale review via 899966b February 3, 2023 07:58

Update packages/eslint-plugin/src/rules/no-floating-promises.ts

899966b

Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

JoshuaKGoldberg requested changes Feb 3, 2023

View reviewed changes

packages/eslint-plugin/src/rules/no-floating-promises.ts Show resolved Hide resolved

remove sourceCode Variable

ab1bf4c

JoshuaKGoldberg approved these changes Feb 3, 2023

View reviewed changes

JoshuaKGoldberg merged commit f330e06 into typescript-eslint:main Feb 3, 2023

github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): [no-floating-promises] error on logical expression #6356

feat(eslint-plugin): [no-floating-promises] error on logical expression #6356

islandryu commented Jan 20, 2023 •

edited

Loading

typescript-eslint bot commented Jan 20, 2023

nx-cloud bot commented Jan 20, 2023 •

edited

Loading

netlify bot commented Jan 20, 2023 •

edited

Loading

islandryu Jan 20, 2023

JoshuaKGoldberg left a comment

codecov bot commented Feb 3, 2023 •

edited

Loading

islandryu commented Feb 3, 2023

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

feat(eslint-plugin): [no-floating-promises] error on logical expression #6356

feat(eslint-plugin): [no-floating-promises] error on logical expression #6356

Conversation

islandryu commented Jan 20, 2023 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Jan 20, 2023

nx-cloud bot commented Jan 20, 2023 • edited Loading

☁️ Nx Cloud Report

netlify bot commented Jan 20, 2023 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

islandryu Jan 20, 2023

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

codecov bot commented Feb 3, 2023 • edited Loading

Codecov Report

islandryu commented Feb 3, 2023

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

islandryu commented Jan 20, 2023 •

edited

Loading

nx-cloud bot commented Jan 20, 2023 •

edited

Loading

netlify bot commented Jan 20, 2023 •

edited

Loading

codecov bot commented Feb 3, 2023 •

edited

Loading