Skip to content

chore(website): prioritize changes done in editor over hash change #6513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2023
Merged

chore(website): prioritize changes done in editor over hash change #6513

merged 3 commits into from
Mar 1, 2023

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 22, 2023 •
edited
Loading

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Feb 22, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 79b0fa0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Feb 22, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 79b0fa0
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63f6ac3e21303f0008737106
😎 Deploy Preview https://deploy-preview-6513--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 22, 2023 •
edited
Loading

Codecov Report

Merging #6513 (79b0fa0) into main (06b96ad) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6513      +/-   ##
==========================================
+ Coverage   90.64%   90.66%   +0.02%     
==========================================
  Files         375      376       +1     
  Lines       12844    12851       +7     
  Branches     3782     3783       +1     
==========================================
+ Hits        11642    11651       +9     
+ Misses        857      856       -1     
+ Partials      345      344       -1
Flag Coverage Δ
unittest 90.66% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ript-estree/src/create-program/describeFilePath.ts 100.00% <0.00%> (ø)
...-estree/src/create-program/createProjectProgram.ts 97.67% <0.00%> (+4.19%) ⬆️

@armano2 armano2 marked this pull request as draft February 22, 2023 22:42
@armano2 armano2 marked this pull request as ready for review February 23, 2023 00:01
@armano2 armano2 added package: website Issues related to the @typescript-eslint website website: playground labels Feb 23, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 played around with this a bunch locally and couldn't trigger the bug. Great!

@bradzacher bradzacher changed the title fix(website): prioritize changes done in editor over hash change chore(website): prioritize changes done in editor over hash change Feb 23, 2023
@JamesHenry
Copy link
Member

@armano2 I reported the strangeness here: quantizor/wait-for-netlify-action#5

Sadly the response is not good! There will not be any maintenance on this action going forward.

I will work on a fork over the weekend to resolve the issue

@bradzacher bradzacher added this pull request to the merge queue Mar 1, 2023
Merged via the queue into main with commit e86802d Mar 1, 2023
@bradzacher bradzacher deleted the fix/do-not-clear-playground-on-load-6336 branch March 1, 2023 13:06
@armano2 armano2 mentioned this pull request Mar 1, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
@JamesHenry
Copy link
Member

Just a follow up to my previous comment: #6513 (comment)

We now have our own lightweight wait-for-netlify action in the repo, so hopefully there should not be any more issues related to the deployment resolution (and if there are we have full control to resolve them)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
package: website Issues related to the @typescript-eslint website website: playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Playground clears portions of text when attempting to type
4 participants
@armano2 @JamesHenry @JoshuaKGoldberg @bradzacher