fix(eslint-plugin): [strict-boolean-expression] support falsy and truthy literals simultaneously #6672

kozlovvski · 2023-03-18T23:16:33Z

PR Checklist

Addresses an existing open issue: fixes Bug: [strict-boolean-expression] using string literal union bypasses allowString: false #6624
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Instead of checking if any of the string/number types is truthy to tell if combined type is truthy, we should do the opposite -> check if any of the types is falsy

typescript-eslint · 2023-03-18T23:16:35Z

Thanks for the PR, @kozlovvski!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2023-03-18T23:16:40Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`c9fa150`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6418684d001987000862a186
😎 Deploy Preview	https://deploy-preview-6672--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

packages/eslint-plugin/src/rules/strict-boolean-expressions.ts

nx-cloud · 2023-03-18T23:24:19Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c9fa150. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

codecov · 2023-03-18T23:36:59Z

Codecov Report

Merging #6672 (c9fa150) into main (58c102d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6672   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         383      383           
  Lines       13035    13036    +1     
  Branches     3841     3842    +1     
=======================================
+ Hits        11366    11367    +1     
  Misses       1303     1303           
  Partials      366      366

Flag	Coverage Δ
unittest	`87.19% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...int-plugin/src/rules/strict-boolean-expressions.ts	`98.91% <100.00%> (+<0.01%)`	⬆️

…nously-in-strict-boolean

Josh-Cena

The fix looks great to me. Just a minor nit.

packages/eslint-plugin/tests/rules/strict-boolean-expressions.test.ts

…nously-in-strict-boolean

JoshuaKGoldberg

Agreed, looks great - thanks!

Kinda nifty how sometimes switching between every and some can fix bugs...

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.54.0` -> `5.56.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.54.0/5.56.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.54.0` -> `5.56.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.54.0/5.56.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.56.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5560-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5550v5560-2023-03-20) [Compare Source](typescript-eslint/typescript-eslint@v5.55.0...v5.56.0) ##### Bug Fixes - **eslint-plugin:** \[member-ordering] check order when optionalityOrder is present with no optional members ([#6619](typescript-eslint/typescript-eslint#6619)) ([6aff431](typescript-eslint/typescript-eslint@6aff431)) - **eslint-plugin:** \[no-misused-promises] avoid unnecessary calls to getContextualType ([#6193](typescript-eslint/typescript-eslint#6193)) ([745cfe4](typescript-eslint/typescript-eslint@745cfe4)) - **eslint-plugin:** \[no-misused-promises] fix incorrect detection of void functions in JSX attributes ([#6638](typescript-eslint/typescript-eslint#6638)) ([9e41cee](typescript-eslint/typescript-eslint@9e41cee)) - **eslint-plugin:** \[strict-boolean-expression] support falsy and truthy literals simultaneously ([#6672](typescript-eslint/typescript-eslint#6672)) ([62ef487](typescript-eslint/typescript-eslint@62ef487)) - **eslint-plugin:** \[strict-boolean-expressions] handle truthy enums ([#6618](typescript-eslint/typescript-eslint#6618)) ([0d0639f](typescript-eslint/typescript-eslint@0d0639f)) - **eslint-plugin:** add TSPropertySignature with TSFunctionType annotation to typeMethod selector ([#6645](typescript-eslint/typescript-eslint#6645)) ([3fc5c63](typescript-eslint/typescript-eslint@3fc5c63)) ##### Features - **eslint-plugin:** add allowNever support to restrict-template-expressions ([#6554](typescript-eslint/typescript-eslint#6554)) ([423f164](typescript-eslint/typescript-eslint@423f164)) ### [`v5.55.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5550-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5541v5550-2023-03-13) [Compare Source](typescript-eslint/typescript-eslint@v5.54.1...v5.55.0) ##### Bug Fixes - **eslint-plugin:** \[no-confusing-void-expression] check sequence expressions for void is in last position ([#6597](typescript-eslint/typescript-eslint#6597)) ([d73d7d3](typescript-eslint/typescript-eslint@d73d7d3)) - **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] fixer should handle parentheses ([#6569](typescript-eslint/typescript-eslint#6569)) ([2d8c196](typescript-eslint/typescript-eslint@2d8c196)) ##### Features - **eslint-plugin:** \[lines-around-comment] add extension rule ([#5327](typescript-eslint/typescript-eslint#5327)) ([d55211c](typescript-eslint/typescript-eslint@d55211c)) - **eslint-plugin:** \[member-ordering] add support for grouping readonly fields ([#6349](typescript-eslint/typescript-eslint#6349)) ([9d3bdfc](typescript-eslint/typescript-eslint@9d3bdfc)) - **eslint-plugin:** \[no-unnecessary-cond] check logical assignments ([#6594](typescript-eslint/typescript-eslint#6594)) ([dbc203a](typescript-eslint/typescript-eslint@dbc203a)) - update TypeScript to 5.0 RC ([#6570](typescript-eslint/typescript-eslint#6570)) ([36ef0e1](typescript-eslint/typescript-eslint@36ef0e1)) - use [@eslint-community](https://github.com/eslint-community) dependencies ([#6603](typescript-eslint/typescript-eslint#6603)) ([5f6ed73](typescript-eslint/typescript-eslint@5f6ed73)) #### [5.54.1](typescript-eslint/typescript-eslint@v5.54.0...v5.54.1) (2023-03-06) **Note:** Version bump only for package [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) ### [`v5.54.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5541-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5540v5541-2023-03-06) [Compare Source](typescript-eslint/typescript-eslint@v5.54.0...v5.54.1) **Note:** Version bump only for package [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.56.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5560-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5550v5560-2023-03-20) [Compare Source](typescript-eslint/typescript-eslint@v5.55.0...v5.56.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) ### [`v5.55.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5550-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5541v5550-2023-03-13) [Compare Source](typescript-eslint/typescript-eslint@v5.54.1...v5.55.0) ##### Features - **parser:** add exported meta object ([#6586](typescript-eslint/typescript-eslint#6586)) ([d05c3d8](typescript-eslint/typescript-eslint@d05c3d8)) #### [5.54.1](typescript-eslint/typescript-eslint@v5.54.0...v5.54.1) (2023-03-06) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) ### [`v5.54.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5541-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5540v5541-2023-03-06) [Compare Source](typescript-eslint/typescript-eslint@v5.54.0...v5.54.1) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1811 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

support falsy and truthy literals simultanously

dcca9d3

kozlovvski commented Mar 18, 2023

View reviewed changes

packages/eslint-plugin/src/rules/strict-boolean-expressions.ts Outdated Show resolved Hide resolved

Merge branch 'main' into 6624-allow-falsy-and-truthy-literals-simulta…

8c64337

…nously-in-strict-boolean

kozlovvski marked this pull request as ready for review March 18, 2023 23:41

kozlovvski and others added 2 commits March 19, 2023 12:36

replace Array.prototype.some condition with Array.prototype.every

3bb1bde

Merge branch 'main' into 6624-allow-falsy-and-truthy-literals-simulta…

257f081

…nously-in-strict-boolean

kozlovvski requested a review from Josh-Cena March 19, 2023 12:53

Merge branch 'main' into 6624-allow-falsy-and-truthy-literals-simulta…

de95784

…nously-in-strict-boolean

bradzacher added the bug Something isn't working label Mar 20, 2023

bradzacher changed the title ~~fix(eslint-plugin): support falsy and truthy literals simultaneously in strict-boolean-expression rule~~ fix(eslint-plugin): [strict-boolean-expression] support falsy and truthy literals simultaneously Mar 20, 2023

Merge branch 'main' into 6624-allow-falsy-and-truthy-literals-simulta…

ddf8919

…nously-in-strict-boolean

Josh-Cena reviewed Mar 20, 2023

View reviewed changes

packages/eslint-plugin/tests/rules/strict-boolean-expressions.test.ts Outdated Show resolved Hide resolved

format test cases to match prettier configuration

ee4b83e

kozlovvski requested a review from Josh-Cena March 20, 2023 11:40

Merge branch 'main' into 6624-allow-falsy-and-truthy-literals-simulta…

c9fa150

…nously-in-strict-boolean

Josh-Cena requested a review from JoshuaKGoldberg March 20, 2023 15:17

JoshuaKGoldberg approved these changes Mar 20, 2023

View reviewed changes

JoshuaKGoldberg merged commit 62ef487 into typescript-eslint:main Mar 20, 2023

github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [strict-boolean-expression] support falsy and truthy literals simultaneously #6672

fix(eslint-plugin): [strict-boolean-expression] support falsy and truthy literals simultaneously #6672

kozlovvski commented Mar 18, 2023

typescript-eslint bot commented Mar 18, 2023

netlify bot commented Mar 18, 2023 •

edited

Loading

nx-cloud bot commented Mar 18, 2023 •

edited

Loading

codecov bot commented Mar 18, 2023 •

edited

Loading

Josh-Cena left a comment

JoshuaKGoldberg left a comment

fix(eslint-plugin): [strict-boolean-expression] support falsy and truthy literals simultaneously #6672

fix(eslint-plugin): [strict-boolean-expression] support falsy and truthy literals simultaneously #6672

Conversation

kozlovvski commented Mar 18, 2023

PR Checklist

Overview

typescript-eslint bot commented Mar 18, 2023

netlify bot commented Mar 18, 2023 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Mar 18, 2023 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Mar 18, 2023 • edited Loading

Codecov Report

Josh-Cena left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

netlify bot commented Mar 18, 2023 •

edited

Loading

nx-cloud bot commented Mar 18, 2023 •

edited

Loading

codecov bot commented Mar 18, 2023 •

edited

Loading