Skip to content

docs: fleshed out RFC and Technical Discussions forms #7059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Addresses #7058 by adding the new checkbox to the existing rfcs.yml template. Then also uses a similar template for technical-discussions.yml.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f023bf5
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/646e10e89cd99d000821c0fc
😎 Deploy Preview https://deploy-preview-7059--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

- label: I have [searched for related discussions](https://github.com/typescript-eslint/typescript-eslint/discussions) and [searched for related issues](https://github.com/typescript-eslint/typescript-eslint/issues) and found none that match my proposal.
required: true
- label: I have [read the FAQ](https://typescript-eslint.io/linting/troubleshooting) and my problem is not listed.
required: true
id: required-checks
type: checkboxes
labels: ['rfc']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussions inherently have a category, so I don't think we need this label?

@nx-cloud
Copy link

nx-cloud bot commented May 24, 2023

bradzacher
bradzacher previously approved these changes May 24, 2023
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@JoshuaKGoldberg JoshuaKGoldberg merged commit 57e8a35 into typescript-eslint:main May 24, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the more-discussion-templates branch May 24, 2023 13:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add an "I have read the guidelines and this fits discussions" checkbox for discussions Docs: Enable Discussion forms
2 participants