Skip to content

chore(website): fix website build #7182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore(website): fix website build #7182

wants to merge 2 commits into from

Conversation

rubiesonthesky
Copy link
Contributor

PR Checklist

Overview

Website builds locally for me now. I'm not sure what the commit message should be in this case.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @rubiesonthesky!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 10, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 373ca60
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64ac62584087d900085da07e
😎 Deploy Preview https://deploy-preview-7182--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rubiesonthesky rubiesonthesky mentioned this pull request Jul 10, 2023
Closed
3 tasks
@rubiesonthesky rubiesonthesky changed the title Fix website build chore(website): Fix website build Jul 10, 2023
@rubiesonthesky rubiesonthesky changed the title chore(website): Fix website build chore(website): fix website build Jul 10, 2023
@nx-cloud
Copy link

nx-cloud bot commented Jul 10, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 373ca60. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg
Copy link
Member

😢 sorry to pull this out from you @rubiesonthesky - but the issue was fixed in v6 which is now merged into main. So I'll go ahead close this PR.

But I appreciate you looking into it and finding a fix! I've seen that you're looking into more and more issues & PRs, which is awesome! ❤️‍🔥

@rubiesonthesky
Copy link
Contributor Author

@JoshuaKGoldberg yeah I understand! Though I think the tsconfig may still be wrong. But unless you enable swc again, maybe it does not matter :)

@rubiesonthesky rubiesonthesky deleted the fix-website-build branch July 13, 2023 16:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Docusaurus builds are broken on main
2 participants
@rubiesonthesky @JoshuaKGoldberg