Skip to content

chore: use workerIdleMemoryLimit in jest tests #7249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rubiesonthesky
Copy link
Contributor

PR Checklist

Overview

Set worker memory limit, so CI does not run out of memory while running them.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @rubiesonthesky!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2b27830
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64b52cc988fe5100080719fc
😎 Deploy Preview https://deploy-preview-7249--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 17, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2b27830. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

@rubiesonthesky
Copy link
Contributor Author

This makes tests really slow on CI. Locally they were little bit faster. It seems also that with node 20 they are leaking a lot, or it’s taking double the time to run.

I think the test runner setup is not really clearing things out or then it’s node that can’t know what to go.

I could try with exposing gc but locally that was not so good option. Of course, trying to compare these runs is difficult because they are so heavily cached and once you try something new, they are no longer using pre-existing cache.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks for the quick fix @rubiesonthesky! Let's try this out. I've got a good feeling about it. 😄

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0fef2e3 into typescript-eslint:main Jul 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Unit tests occasionally run out of memory in CI
2 participants