-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: use workerIdleMemoryLimit in jest tests #7249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use workerIdleMemoryLimit in jest tests #7249
Conversation
Thanks for the PR, @rubiesonthesky! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This makes tests really slow on CI. Locally they were little bit faster. It seems also that with node 20 they are leaking a lot, or it’s taking double the time to run. I think the test runner setup is not really clearing things out or then it’s node that can’t know what to go. I could try with exposing gc but locally that was not so good option. Of course, trying to compare these runs is difficult because they are so heavily cached and once you try something new, they are no longer using pre-existing cache. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 thanks for the quick fix @rubiesonthesky! Let's try this out. I've got a good feeling about it. 😄
PR Checklist
Overview
Set worker memory limit, so CI does not run out of memory while running them.