Skip to content

chore: enable consistent-indexed-object-style and lint #7353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 5, 2023
Merged

chore: enable consistent-indexed-object-style and lint #7353

merged 8 commits into from
Aug 5, 2023

Conversation

nevvada
Copy link
Contributor

@nevvada nevvada commented Jul 28, 2023 •
edited
Loading

PR Checklist

Overview

this PR:

  • enables consistent-indexed-object-style eslint rule
  • addresses all files that had lint errors due to this rule previously being ignored

all updated instances were legitimate places that needed to be updated per the lint rule

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @nevvada!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 28, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 43dc20b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64cea78dc682b10008dcfc7f
😎 Deploy Preview https://deploy-preview-7353--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 28, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 43dc20b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 35 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Jul 28, 2023 •
edited
Loading

Codecov Report

Merging #7353 (316e7df) into main (c869aa1) will increase coverage by 0.01%.
Report is 40 commits behind head on main.
The diff coverage is 65.21%.

❗ Current head 316e7df differs from pull request most recent head 43dc20b. Consider uploading reports for the commit 43dc20b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7353      +/-   ##
==========================================
+ Coverage   87.40%   87.41%   +0.01%     
==========================================
  Files         381      381              
  Lines       13313    13316       +3     
  Branches     3934     3936       +2     
==========================================
+ Hits        11636    11640       +4     
- Misses       1292     1298       +6     
+ Partials      385      378       -7
Flag Coverage Δ
unittest 87.41% <65.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/type-utils/src/predicates.ts 21.73% <0.00%> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts 93.33% <ø> (ø)
packages/typescript-estree/src/simple-traverse.ts 72.72% <ø> (ø)
packages/utils/src/ts-eslint/CLIEngine.ts 33.33% <ø> (ø)
packages/utils/src/ts-eslint/Linter.ts 50.00% <ø> (ø)
packages/utils/src/ts-eslint/SourceCode.ts 50.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts 100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts 30.03% <31.25%> (ø)
...eslint-plugin/src/rules/type-annotation-spacing.ts 83.09% <50.00%> (+1.40%) ⬆️
...eslint-plugin/src/rules/consistent-type-exports.ts 97.67% <100.00%> (ø)
... and 14 more

nevvada
nevvada commented Jul 29, 2023
View reviewed changes
packages/rule-schema-to-typescript-types/src/index.ts
@@ -69,9 +69,7 @@ function compileSchema(

const refMap = new Map<string, string>();
// we only support defs at the top level for simplicity
const defs = (schema.$defs ?? schema.definitions) as
| Record<string, JSONSchema4>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this one since schema.$defs and schema.definitions are both Record<string, JSONSchema4> | undefined;

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nevvada nevvada marked this pull request as ready for review July 29, 2023 00:51
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

I can apply the suggestion & merge in.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 4087f48 into typescript-eslint:main Aug 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nevvada @JoshuaKGoldberg