Skip to content

feat: update abstract class node #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2019
Merged

feat: update abstract class node #75

merged 1 commit into from
Jan 19, 2019

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Jan 19, 2019

This PR changes TSAbstractClassDeclaration to ClassDeclaration

  • estree
  • parser
  • plugin
  • regression tests for no-shadow and no-undef

fixes: #20

@armano2 armano2 requested a review from a team January 19, 2019 06:04
@codecov
Copy link

codecov bot commented Jan 19, 2019 •
edited
Loading

Codecov Report

Merging #75 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #75      +/-   ##
=========================================
+ Coverage   94.77%   94.8%   +0.02%     
=========================================
  Files          48      48              
  Lines        2470    2465       -5     
  Branches      381     380       -1     
=========================================
- Hits         2341    2337       -4     
  Misses         77      77              
+ Partials       52      51       -1
Impacted Files Coverage Δ
...ages/typescript-eslint-parser/src/analyze-scope.ts 93.22% <ø> (-0.03%) ⬇️
packages/typescript-estree/src/ast-node-types.ts 100% <ø> (ø) ⬆️
...kages/eslint-plugin-typescript/lib/rules/indent.js 100% <ø> (ø) ⬆️
...kages/typescript-eslint-parser/src/visitor-keys.ts 100% <ø> (ø) ⬆️
...t-plugin-typescript/lib/rules/class-name-casing.js 94.11% <100%> (-0.62%) ⬇️
packages/typescript-estree/src/convert.ts 94.59% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab64809...3ec0ed7. Read the comment docs.

@JamesHenry JamesHenry merged commit 5d8db8d into typescript-eslint:master Jan 19, 2019
@armano2 armano2 deleted the abstract-class branch January 19, 2019 17:55
armanio123 pushed a commit to armanio123/typescript-eslint that referenced this pull request Jan 24, 2019
@mightyiam @JamesHenry
Fix: no-triple-slash-reference (fixes typescript-eslint#75)
2b8b2b9
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Luckeu pushed a commit to Luckeu/typescript-eslint that referenced this pull request Jun 27, 2024
@antfu
feat(ts/lines-around-comment): add missing afterHashbangComment in …
391335b 
…schema, fix typescript-eslint#75 (typescript-eslint#161)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@j-f1 j-f1 j-f1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TSAbstractClassDeclaration are not defined in the scope (no-undef)
3 participants
@armano2 @JamesHenry @j-f1