Skip to content

fix(eslint-plugin): [no-confusing-void-expression] handle unfixable cases #7674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix(eslint-plugin): [no-confusing-void-expression] handle unfixable cases #7674

merged 3 commits into from
Oct 16, 2023

Conversation

yeonjuan
Copy link
Contributor

PR Checklist

Overview

This change will prevent autofixes in certain cases. Before the change, it worked like this

  const f = function () {
          let num = 1;
          return num ? console.log('foo') : num;
  };

// after fix
  const f = function () {
          let num = 1;
          num ? console.log('foo') : num;
  };

I changed to not apply fix to node which can be conditionally void.

let num = 1;
const foo = () => num ? console.log('foo') : num;

const f = function () {
     let num = 1;
     return num ? console.log('foo') : num;
};

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 71f9ef4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/652c029ef3b5380008d16691
😎 Deploy Preview https://deploy-preview-7674--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 89 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 19, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71f9ef4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 from NxCloud.

@yeonjuan yeonjuan force-pushed the fix/6187 branch 2 times, most recently from 22f78d9 to ef650d0 Compare September 28, 2023 12:36
JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 10, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - nice spot on checking ts.TypeFlags.VoidLike! This function works perfectly but just has a bit of dead code I think. Requesting changes just on that.

Super thorough tests, too! 👏

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 10, 2023
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 15, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 7e52f27 into typescript-eslint:main Oct 16, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-confusing-void-expression] Wrong autofix for a ? void : T
2 participants
@yeonjuan @JoshuaKGoldberg