chore: don't clear TSServer Project Service between repo tests #7801
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -17,7 +14,6 @@ export function clearCaches(): void { | |||
| clearProgramCacheOriginal(); | |||
| clearWatchCaches(); | |||
| clearTSConfigMatchCache(); | |||
| clearTSServerProjectService(); | |||
There was a problem hiding this comment.
Whoops, sorry for the accidental tag (meant to re-draft). Looks like CI still takes quite a while. We'll need to investigate more.
There was a problem hiding this comment.
29m 5s
Run npx nx test eslint-plugin --coverage=false
> nx run eslint-plugin:test --coverage=false
PASS tests/rules/padding-line-between-statements.test.ts (20.724 s, 699 MB heap size)
PASS tests/rules/type-annotation-spacing.test.ts (16.747 s, 1151 MB heap size)
...
PR Checklist
Overview
createProjectService()has no parameters. So I'm hopeful it can just ... stick around between tests, regardless of what physical or virtual file system names they use? If not, we'll have to look into using its APIs to clear files...