Skip to content

chore: fix miscellaneous no-unnecessary-condition violations #7834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 13, 2023
Merged

chore: fix miscellaneous no-unnecessary-condition violations #7834

merged 4 commits into from
Nov 13, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Makes progress on fixing existing @typescript-eslint/no-unnecessary-condition violations. Part of a series of PRs that split this up, as there are many of them.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2511f47
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65521fa15035b10008011ade
😎 Deploy Preview https://deploy-preview-7834--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Oct 25, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 412dbe5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 31, 2023 19:35
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Nov 10, 2023
bradzacher
bradzacher previously approved these changes Nov 10, 2023
View reviewed changes
packages/type-utils/src/getTypeArguments.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

futureisnow_oldman

@bradzacher
Copy link
Member

oh wait - this is a breaking change right now because you removed a public function from type-utils.

now that you've cleaned it up - will need to add it back and @deprecate it for the next release

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Nov 10, 2023
@bradzacher bradzacher added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting response Issues waiting for a reply from the OP or another party labels Nov 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit 8e87fac into typescript-eslint:main Nov 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher