chore(typescript-estree): fixed no-unnecessary-condition complaints #7835
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -25,8 +25,7 @@ let warnedAboutTSVersion = false; | |||
|
|
|||
| export function warnAboutTSVersion(parseSettings: ParseSettings): void { | |||
| if (!isRunningSupportedTypeScriptVersion && !warnedAboutTSVersion) { | |||
| const isTTY = | |||
| typeof process === 'undefined' ? false : process.stdout?.isTTY; | |||
| const isTTY = typeof process === 'undefined' ? false : process.stdout.isTTY; | |||
There was a problem hiding this comment.
IIRC this is actually necessary
#1619
There was a problem hiding this comment.
🤔 I don't like adding support for something that's not possible per type definitions... process.stdout is supposed to exist. If some bundler removes it then they're telling a lie to packages like us. Hmm. #7896
There was a problem hiding this comment.
Yeah generally I'd say "I don't care" if someone's playing funny-buggers like that -- but the reason we accepted it was because it's prettier and they're one of our biggest consumers and we ❤️ them
There was a problem hiding this comment.
I do ❤️ Prettier 😄
PR Checklist
Overview
Makes progress on fixing existing
@typescript-eslint/no-unnecessary-conditionviolations underpackages/typescript-estree. Part of a series of PRs that split this up, as there are many of them.