chore: enable prefer-nullish-coalescing internally #7955
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Can we turn it on with ignoreConditionalTests?
I think that using ?? in conditional tests is less clear.
Consider the downlevelled output:
if (x || y) { }
// vs
if (x ?? y) { }
// downlevelled to
if (x != null ? x : y) { }I think it's a whole lot less clear.
Actually I'm going to go as far as advocating for flipping the default in v7 - #8243
…#7955) * chore: enable prefer-nullish-calescing internally * A couple complaints * One last complaint * Enable ignoreConditionalTests
PR Checklist
Overview
Fixes up most of the last few violations of @typescript-eslint/prefer-nullish-coalescing. Ignores primitives because we tend to do "fun" things with strings.