Skip to content

feat: export types of ts rule option #8564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat: export types of ts rule option #8564

wants to merge 2 commits into from

Conversation

linlinyang
Copy link

Support eslint flat config

Example:

import type { Linter } from 'eslint';
import type {ruleOptions} from '@typescript-eslint/eslint-plugin';

// And than define rules:
type TSRules = {
  [K in keyof ruleOptions]?: Linter.RuleEntry<ruleOptions[K]>;
};
const rules: TSRules = {
  'accessor-pairs': 'error',
  'array-type': ['error', {
     readonly: 'array'
   }]
};

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @linlinyang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 27, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6e6064e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65ddc254546d42000873d770
😎 Deploy Preview https://deploy-preview-8564--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 27, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6e6064e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

bradzacher
bradzacher requested changes Feb 27, 2024
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per our contributing guide we ask that you raise an issue to discuss the change before raising a PR.
https://typescript-eslint.io/contributing/pull-requests

You have also provided no real context in our PR description.

Please file an issue to describe your intended usecase so we can discuss it and the correct course of action.

@bradzacher bradzacher closed this Feb 27, 2024
@bradzacher bradzacher added the please fill out the template we have the processes for good reasons 😔 label Feb 27, 2024
@linlinyang linlinyang changed the title Export types of ts rule option. feat: Export types of ts rule option. Feb 27, 2024
@linlinyang linlinyang changed the title feat: Export types of ts rule option. feat: export types of ts rule option. Feb 27, 2024
@linlinyang linlinyang changed the title feat: export types of ts rule option. feat: export types of ts rule option Feb 27, 2024
This was referenced Feb 27, 2024
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher requested changes

Assignees
No one assigned
Labels
please fill out the template we have the processes for good reasons 😔
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linlinyang @bradzacher