Skip to content

feat: export types of ts rule option #8565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

feat: export types of ts rule option #8565

wants to merge 5 commits into from

Conversation

linlinyang
Copy link

Support eslint flat config

Example:

import type { Linter } from 'eslint';
import type {ruleOptions} from '@typescript-eslint/eslint-plugin';

// And than define rules:
type TSRules = {
  [K in keyof ruleOptions]?: Linter.RuleEntry<ruleOptions[K]>;
};
const rules: TSRules = {
  'accessor-pairs': 'error',
  'array-type': ['error', {
     readonly: 'array'
   }]
};

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @linlinyang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 27, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 779ffa9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65ddd2f583dcdb0008a5e444
😎 Deploy Preview https://deploy-preview-8565--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 27, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 779ffa9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@auvred
Copy link
Member

auvred commented Feb 27, 2024 •
edited
Loading

Copying from #8564 (review)

as per our contributing guide we ask that you raise an issue to discuss the change before raising a PR.
https://typescript-eslint.io/contributing/pull-requests

@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (4bc6944) to head (779ffa9).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8565      +/-   ##
==========================================
- Coverage   87.84%   87.05%   -0.79%     
==========================================
  Files         397      251     -146     
  Lines       13844    12268    -1576     
  Branches     4073     3867     -206     
==========================================
- Hits        12161    10680    -1481     
+ Misses       1381     1316      -65     
+ Partials      302      272      -30
Flag Coverage Δ
unittest 87.05% <ø> (-0.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 146 files with indirect coverage changes

@bradzacher bradzacher closed this Feb 27, 2024
@bradzacher
Copy link
Member

Please don't raise duplicate PRs

@auvred auvred mentioned this pull request Feb 28, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linlinyang @auvred @bradzacher