fix(eslint-plugin): [no-unnecessary-type-assertion] combine template literal check with const variable check
#8820
Conversation
|
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8820 +/- ##
==========================================
- Coverage 88.02% 87.37% -0.65%
==========================================
Files 405 255 -150
Lines 14089 12510 -1579
Branches 4125 3927 -198
==========================================
- Hits 12402 10931 -1471
+ Misses 1382 1304 -78
+ Partials 305 275 -30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR Checklist
Overview
In #8740, new logic was added for template literals. This logic was wrongly added as a precondition, when it needs to be combined with the existing
constvariable declaration logic.validtests added in fix(eslint-plugin): [no-unnecessary-type-assertion] avoid remove const casting on template literals with expressions inside #8740 are actually unnecessary (but are too complex to be detected by the current logic). Changedconsttolet, so that the type assertions are truly necessary.isLiteralVariableDeclarationChangingTypeWithConsttoisImplicitlyNarrowedConstDeclaration.