-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: use parserOptions.projectService internally #9659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use parserOptions.projectService internally #9659
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7d5215e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v8 #9659 +/- ##
=======================================
Coverage 88.05% 88.05%
=======================================
Files 402 402
Lines 13657 13657
Branches 3967 3967
=======================================
Hits 12026 12026
Misses 1322 1322
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. |
PR Checklist
Overview
Simplifies our
eslint.config.mjs
a bit by usingparserOptions.projectService: true
instead of a largerparserOptions.project
array. There was onepackages/eslint-plugin/eslint-recommended-raw.d.ts
file missing from itstsconfig.json
.This is an example of the need for
additionalNodeTypeFiles
from eslint-community/eslint-plugin-eslint-plugin#484. Switching to the project service meant we got project references support for free, which switched the linted files fromdist/*/.d.ts
to the sourceast-spec.ts
.💖