Skip to content

chore: use parserOptions.projectService internally #9659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Simplifies our eslint.config.mjs a bit by using parserOptions.projectService: true instead of a larger parserOptions.project array. There was one packages/eslint-plugin/eslint-recommended-raw.d.ts file missing from its tsconfig.json.

This is an example of the need for additionalNodeTypeFiles from eslint-community/eslint-plugin-eslint-plugin#484. Switching to the project service meant we got project references support for free, which switched the linted files from dist/*/.d.ts to the source ast-spec.ts.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 29, 2024 11:56
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7d5215e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66a796226c5828000991180a
😎 Deploy Preview https://deploy-preview-9659--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7d5215e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (90432a2) to head (7d5215e).
Report is 1 commits behind head on v8.

Additional details and impacted files
@@           Coverage Diff           @@
##               v8    #9659   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files         402      402           
  Lines       13657    13657           
  Branches     3967     3967           
=======================================
  Hits        12026    12026           
  Misses       1322     1322           
  Partials      309      309           
Flag Coverage Δ
unittest 88.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 838dd0c into typescript-eslint:v8 Jul 30, 2024
60 of 62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the project-service-internally branch July 30, 2024 12:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants