Skip to content

feat(eslint-plugin): [no-unnecessary-type-parameters] promote to strict #9662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2024
Merged

feat(eslint-plugin): [no-unnecessary-type-parameters] promote to strict #9662

merged 2 commits into from
Jul 29, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Bumps the rule's meta.docs.recommended and removes its docs page's admonition.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 29, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4b82718
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66a793df79d1c800080e4b89
😎 Deploy Preview https://deploy-preview-9662--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team July 29, 2024 13:06
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 29, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4b82718. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

kirkwaiblinger
kirkwaiblinger approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

promotion

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 29, 2024
@JoshuaKGoldberg
Copy link
Member Author

CI flake.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6cebdf6 into typescript-eslint:v8 Jul 29, 2024
60 of 62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the no-unnecessary-type-parameters-strict branch July 29, 2024 15:48
@github-actions github-actions bot mentioned this pull request Jul 29, 2024
Closed
2 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @kirkwaiblinger