Skip to content

fix(rule-tester): support ESLint >=9.5.0's new language internal #9677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

In theory, we could add in the full types from @eslint/core describing (Flat)ESLint.Language. But given that language support is so new in ESLint, and this PR needs to land before we release v8 as stable, I'd rather defer that to a followup.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit cd23ad1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66a91d1587382a0008c854b3
😎 Deploy Preview https://deploy-preview-9677--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 30, 2024

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft July 30, 2024 17:21
@JoshuaKGoldberg
Copy link
Member Author

Superseded by #9678.

@JoshuaKGoldberg JoshuaKGoldberg deleted the rule-tester-eslint-language branch July 30, 2024 17:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant