fix(rule-tester): provide Linter a cwd in its constructor #9678
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 09c739c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
| @@ -917,6 +915,7 @@ export class RuleTester extends TestFramework { | |||
|
|
|||
| const hasMessageOfThisRule = messages.some(m => m.ruleId === ruleName); | |||
|
|
|||
| // console.log({ messages }); | |||
There was a problem hiding this comment.
| // console.log({ messages }); |
There was a problem hiding this comment.
oop will do this on the branch
PR Checklist
Overview
Per #9676 (comment), uses the more friendly
Lintercwdconstructor param instead of working around ESLint's internals.I see this PR as finishing what #9603 started & should have finished: fully embracing the new "flat"
Linter's paradigm of setting thecwdfrom the beginning.💖