feat(eslint-plugin): [no-misused-promises] check array predicate return #9955
Conversation
|
Thanks for the PR, @yeonjuan! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9955 +/- ##
==========================================
+ Coverage 88.67% 88.69% +0.01%
==========================================
Files 425 426 +1
Lines 14799 14820 +21
Branches 4304 4310 +6
==========================================
+ Hits 13123 13144 +21
Misses 1533 1533
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| node.callee.property.type === AST_NODE_TYPES.Identifier && | ||
| ARRAY_PREDICATE_FUNCTIONS.has(node.callee.property.name) |
There was a problem hiding this comment.
| node.callee.property.type === AST_NODE_TYPES.Identifier && | |
| ARRAY_PREDICATE_FUNCTIONS.has(node.callee.property.name) | |
| ARRAY_PREDICATE_FUNCTIONS.has(getStaticMemberAccessValue(node.callee)) |
[Refactor] Now that #9836 is already merged, we can use a nice utility function for this!
| return tsutils | ||
| .typeParts(type) | ||
| .some(t => checker.isArrayType(t) || checker.isTupleType(t)); |
There was a problem hiding this comment.
[Bug] I think we should use unionTypeParts and intersectionTypeParts here, because the rule doesn't report on this code:
declare const array: (string[] & {foo: 'bar'}) | (number[] & {bar: 'foo'})
array.every(() => Promise.resolve(true));
PR Checklist
Overview