Don't pass deprecated options to Completion request #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecated options "includeExternalModuleExports" and "includeInsertTextCompletions" are now passed as global, non-deprecated typescript preferences. To achieve that, added those as default preferences to the preferences object that the user can override. Also switch to non-deprecated "CompletionInfo" request and handle "isIncomplete" flag (I don't know when typescript actually makes that "true") and fix some Completion-related types (use LSP types instead of TSC types).
|
Now I've realized why the |
Well, it's fine for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecated options "includeExternalModuleExports" and "includeInsertTextCompletions" are now passed as global, non-deprecated typescript preferences.
To achieve that, added those as default preferences to the preferences object that the user can override.
Also switch to non-deprecated "CompletionInfo" request and handle "isIncomplete" flag (it is used when suggesting global import completions when
includeCompletionsForImportStatementsandincludeCompletionsWithInsertTexttypescript preferences are enabled) and fix some Completion-related types (use LSP types instead of TSC types).@apexskier