Skip to content

Conversation

FrankYFTang
Copy link
Collaborator

@FrankYFTang FrankYFTang requested a review from grhoten July 3, 2025 01:49
@FrankYFTang
Copy link
Collaborator Author

@grhoten I am not sure this is the right fix. But if we do not document it doxygen will consider it missing info and give us warning

Copy link
Member

@grhoten grhoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I'm not sure that this is the right fix. The new documentation in this pull request isn't adding non-obvious information. The typedef is trying to emulate Java's super keyword, and minimize/avoid the C++ multiple inheritance. If you ever have to move a class around in the class hierarchy, this can be "super" convenient. 😀

So it's helpful to have. It's not meaningful to document from an API perspective.

Would using TYPEDEF_HIDES_STRUCT = YES help? That may require the least maintenance.

I would also be agreeable to surrounding the typedefs with /// @cond and /// @endcond, or making them all private.

The super usage is used a lot within a class, especially in the constructors. I'm not sure that it's used nor helpful outside of a given class. So making it private may be OK.

@FrankYFTang
Copy link
Collaborator Author

Would using TYPEDEF_HIDES_STRUCT = YES help? That may require the least maintenance.

no. Warning still there. I do not think it is a struct here.

@FrankYFTang FrankYFTang requested a review from grhoten July 8, 2025 00:24
@FrankYFTang
Copy link
Collaborator Author

PTAL

Copy link
Member

@grhoten grhoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@grhoten
Copy link
Member

grhoten commented Jul 8, 2025

Thanks for the change.

@FrankYFTang FrankYFTang merged commit f55127e into unicode-org:main Jul 8, 2025
6 checks passed
@FrankYFTang FrankYFTang deleted the addSuperComment branch July 8, 2025 03:03
deonajulary06 pushed a commit that referenced this pull request Aug 21, 2025
* Add comment for super class documentation Fix 147

* Fix by using @cond/@endcond

* change // to ///
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants