-
-
Notifications
You must be signed in to change notification settings - Fork 16
Add comment for super class documentation Fix 147 #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@grhoten I am not sure this is the right fix. But if we do not document it doxygen will consider it missing info and give us warning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I'm not sure that this is the right fix. The new documentation in this pull request isn't adding non-obvious information. The typedef is trying to emulate Java's super keyword, and minimize/avoid the C++ multiple inheritance. If you ever have to move a class around in the class hierarchy, this can be "super" convenient. 😀
So it's helpful to have. It's not meaningful to document from an API perspective.
Would using TYPEDEF_HIDES_STRUCT = YES
help? That may require the least maintenance.
I would also be agreeable to surrounding the typedefs with /// @cond
and /// @endcond
, or making them all private.
The super usage is used a lot within a class, especially in the constructors. I'm not sure that it's used nor helpful outside of a given class. So making it private may be OK.
no. Warning still there. I do not think it is a struct here. |
cee0142
to
b4ac0c4
Compare
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
Thanks for the change. |
* Add comment for super class documentation Fix 147 * Fix by using @cond/@endcond * change // to ///
#147