Skip to content

Add test tags, initially for u: options #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Add test tags, initially for u: options #1050

merged 2 commits into from
Mar 31, 2025

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Mar 4, 2025

After #1012, the u:locale option has Draft status, while u:id and u:dir are RECOMMENDED. However, the tests for all three are in the same file, and indistinguishable from eahc other.

We should for now drop the rather minimal tests for u:locale, and add more comprehensive tests when the status changes.

See latest comments, as the PR now keeps the tests, but adds an array of tags to them.

@eemeli eemeli added the test-suite Issue pertains to tests label Mar 4, 2025
@eemeli eemeli requested review from aphillips and catamorphism March 4, 2025 04:17
Copy link
Collaborator

@catamorphism catamorphism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine, but why not add a new file with the u:locale tests rather than removing them? (I realize it's just two tests, but it might still be good to keep what we have.)

@eemeli
Copy link
Collaborator Author

eemeli commented Mar 4, 2025

They'll still be here in the git commit history, and these tests are really rather simple.

@aphillips
Copy link
Member

Stepping back for a moment... we need to develop a way to manage items in draft. We should have tests for new functions and options. People who implement these should be able to test them. So dumpstering these tests feels bad. Can we add a test status like "draft" so users can omit the things they didn't implement?

@eemeli
Copy link
Collaborator Author

eemeli commented Mar 4, 2025

A better solution would be one that separately identifies each of the features that are not REQUIRED, as we ought to also enable the testing and validation of features that are RECOMMENDED or OPTIONAL.

@aphillips
Copy link
Member

Draft should be separate from MUST/SHOULD/MAY. We need both.

@eemeli eemeli force-pushed the drop-u-locale-tests branch from 0a81c2a to 93223c2 Compare March 26, 2025 00:16
@eemeli eemeli changed the title Drop tests relying on u:locale Add test tags, initially for u: options Mar 26, 2025
eemeli added a commit to messageformat/messageformat that referenced this pull request Mar 26, 2025
@eemeli
Copy link
Collaborator Author

eemeli commented Mar 26, 2025

The PR has been rebased and refactored, such that it now keeps the tests, and add tags for them. The tests/README.md is updated with an explanation for them, along with a listing of available tags.

For an example use case, see this JS implementation commit which skips all tests with a 'u:locale' tag.

@eemeli eemeli requested review from catamorphism and mihnita March 26, 2025 00:33
Copy link
Collaborator

@catamorphism catamorphism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea with the tags!

@@ -50,6 +50,20 @@ is not included in the schema,
as it is intended to be an umbrella category
for implementation-specific errors.

## Test Tags

Some of the tests are for functionality that is not stable,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. Items that are not MUST are stable, just not required.

@aphillips aphillips merged commit 9c40277 into main Mar 31, 2025
2 checks passed
@aphillips aphillips deleted the drop-u-locale-tests branch March 31, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-suite Issue pertains to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants