Skip to content

Add requirement and stability level to the tests schema #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mihnita
Copy link
Collaborator

@mihnita mihnita commented Mar 17, 2025

No description provided.

@aphillips aphillips added Agenda+ Requested for upcoming teleconference test-suite Issue pertains to tests LDML48 LDML48 Release labels Mar 17, 2025
Copy link
Collaborator

@catamorphism catamorphism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer labelling each separate non-required non-stable part of functionality with a unique identifier, but I'm not opposed to the tagging proposed here -- I just don't find it particularly useful.

I do, however, think that any such tags should not only be introduced to the schema, but also applied to the test data.

@aphillips
Copy link
Member

I do, however, think that any such tags should not only be introduced to the schema, but also applied to the test data.

Once we agreed on the design, then we should modify all of the tests to match.

I would prefer labelling each separate non-required non-stable part of functionality with a unique identifier, but I'm not opposed to the tagging proposed here -- I just don't find it particularly useful.

I'm not sure I follow. Can you give an example? I can see having an identifier for each test, but their use would be separate. These tags would allow one to select (or de-select) tests based on stability level or based on requirement level. The latter isn't that useful, since presumably most implementations would implement most optional behavior and only need to de-select specific tests.

@aphillips
Copy link
Member

closing in 2025-03-24 call in favor of a revision of #1050

@aphillips aphillips closed this Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agenda+ Requested for upcoming teleconference LDML48 LDML48 Release test-suite Issue pertains to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants