Change the "pattern selection" text #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR #385 I made the [comment](#385 (comment)) which suggested a different approach to pattern selection. This PR addresses that comment.
eemeli
reviewed
Jun 6, 2023
- Make the text use semantic breaks. - Make the terminology consistent with the ABNF. In particular, the term `selector` now refers to the entire `match` statement and the term `expression` is used to refer to a specific selector expression.
eemeli
approved these changes
Jun 6, 2023
| When a _message_ contains a _match_ statement with one or more _expressions_, the implementation needs to determine which _variant_ will be used to provide the _pattern_ for the formatting operation. | ||
| This is done by ordering the available _variant_ statements according to their _key_ values. | ||
|
|
||
| The number of _keys_ in each _variant_ **_MUST_** equal the number of _expressions_ in the _selectors_. |
There was a problem hiding this comment.
The styling we have in the readme for normative key words doesn't quite match this:
message-format-wg/spec/README.md
Lines 62 to 64 in 0a8281c
I don't really mind what we use, as long as we're consistent.
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
|
@eemeli Thanks for the review. I have committed your changes to the line-breaks. The wording change was also committed (since it was an improvement/oversight on my part). |
mihnita
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #385 from @catamorphism I made the comment which suggested a different approach to pattern selection. This PR addresses that comment.