Make pattern selection example 3 clearer #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editorial changes to make this example easier to understand.
eemeli
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
This text is indeed less clunky. Needs newlines, though.
I liked the > styling you used for the example in #388. Should we apply that to all examples, and mention somewhere that such text is non-normative? Then we wouldn't need to specify that at every instance.
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
* Update LICENSE copyright date * Include license referece in readme * Linkify license * Update LICENSE and contribution info (#390) * Update LICENSE and contribution info * Update README.md * Create CONTRIBUTING.md * Update README.md * Fix link to ABNF in readme part of spec * Update agenda.md * Update agenda.md * Harmonise spec style (#392) --------- Co-authored-by: Eemeli Aro <eemeli@mozilla.com>
|
@aphillips I added a merge commit from |
stasm
approved these changes
Jun 19, 2023
cdaringe
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editorial changes to make this example easier to understand. (Taken from comments on PR #385)