Fix segmentation tests #1075
Merged
Fix segmentation tests #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
previously approved these changes
Mar 24, 2025
markusicu
previously approved these changes
Mar 24, 2025
Well, this band aid is too strong already, I am getting failures left and right from things that use unary-query-expression (which is not supported by some of the symbol tables). So I will revert that safety, keep the redundant =true where we know its absence causes a bug in test data, and deal with #1073 first on my way to #1074. |
markusicu
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never return(Not doing that, see below.)falsefrom an override of applyPropertyAlias; this is a band-aid for Never use ICU properties #1074 (and caused segmentation test generation to fail with empty sets), but does not fix the issue systematically.