-
Notifications
You must be signed in to change notification settings - Fork 179
Run tests/suites using custom selection from command line #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…stNode for being able to manage several TestList undependently instead of a single one
…s TestListNode for being able to manage several TestList undependently instead of a single one" This reverts commit c92794c.
Damned, problem with VS 2008 again |
Did you have time for checking this ? Thanks ;) |
Oops, wrong button I closed pull request |
Sorry for the long delay; I have looked but I have not reviewed in detail. Would be happy to see others' opinions. |
Any news ? Thanks |
Hi Patrick, |
It might be just me, but I feel that this pull is just too big for what it is adding. In a previous pull request I suggested starting small, and I'd like to stick to that. |
It adds 3 new classes (SuitePredicate, ArgumentsReader, PredicateCmdBuilder) and make minor changes to existing files. The 30% of the code is for testing the feature. Not that big for me since it is a complete feature and can evolute, more arguments could be added in the future (with the parameterized tests for example). Arguments reading is a nightmare if you don't use a parser. I could have written the code shortly but I think it is time to write some "clean code" instead of keeping the using "C" way-to-do legacy, what do you think ? Thanks |
Depends if "clean code" breaks people who are stuck using gcc 4.8.4 on
Ubuntu 14_04 LTS...
…Sent from my Nexus 6P
On 16 Jan 2017 3:56 pm, "Gabriel Schlozer" ***@***.***> wrote:
It adds 3 new classes (SuitePredicate, ArgumentsReader,
PredicateCmdBuilder) and make minor changes to existing files. The 30% of
the code is for testing the feature.
Not that big for me since it is a complete feature and can evolute, more
arguments could be added in the future (with the parameterized tests for
example). Arguments reading is a nightmare if you don't use a parser.
I could have written the code shortly but I think it is time to write some
"clean code" instead of keeping the using "C" way-to-do legacy, what do you
think ?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#132 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEy9nFR8szZGHzRr2UJR_834tTJPfk_Jks5rS5M6gaJpZM4J44UZ>
.
|
Sorry, @killoctal, but I'm going to stick to my guns here. Let's start small as I suggested and just add support for running one suite, explicitly, using |
Commands:
Special feature: You do not have to specify explicitely --test and --suite, you
can mix suite names and test names and the cmd will find the way. The
constraint is that it must have no arguments beginning with --.
For disabling this feature, set allowImplicitArgs=false
Usage examples:
Explicit :
myTests.exe --suite MySuite1 MyOtherSuite --test MySpecialTest MyOtherTest
Implicit :
myTests.exe MySpecialTest MyOtherTest MySuite1