Skip to content

Run tests/suites using custom selection from command line #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 33 commits into from

Conversation

killoctal
Copy link
Contributor

Commands:

  • --test One or multiple test names to execute, can be combined with --suite
  • --suite One or multiple suite names to execute, can be combined with --test

Special feature: You do not have to specify explicitely --test and --suite, you
can mix suite names and test names and the cmd will find the way. The
constraint is that it must have no arguments beginning with --.
For disabling this feature, set allowImplicitArgs=false

Usage examples:
Explicit :
myTests.exe --suite MySuite1 MyOtherSuite --test MySpecialTest MyOtherTest
Implicit :
myTests.exe MySpecialTest MyOtherTest MySuite1

@killoctal
Copy link
Contributor Author

Damned, problem with VS 2008 again

@killoctal
Copy link
Contributor Author

Did you have time for checking this ? Thanks ;)

@killoctal killoctal closed this Sep 30, 2016
@killoctal
Copy link
Contributor Author

Oops, wrong button I closed pull request

@killoctal killoctal reopened this Sep 30, 2016
@pjohnmeyer
Copy link
Member

Sorry for the long delay; I have looked but I have not reviewed in detail. Would be happy to see others' opinions.

@killoctal
Copy link
Contributor Author

Any news ? Thanks

@killoctal
Copy link
Contributor Author

Hi Patrick,
Did you take a decision about this pull request ?
Thank you :)

@pjohnmeyer
Copy link
Member

It might be just me, but I feel that this pull is just too big for what it is adding.

In a previous pull request I suggested starting small, and I'd like to stick to that.

@killoctal
Copy link
Contributor Author

It adds 3 new classes (SuitePredicate, ArgumentsReader, PredicateCmdBuilder) and make minor changes to existing files. The 30% of the code is for testing the feature.

Not that big for me since it is a complete feature and can evolute, more arguments could be added in the future (with the parameterized tests for example). Arguments reading is a nightmare if you don't use a parser.

I could have written the code shortly but I think it is time to write some "clean code" instead of keeping the using "C" way-to-do legacy, what do you think ?

Thanks

@grahamreeds
Copy link
Contributor

grahamreeds commented Jan 17, 2017 via email

@pjohnmeyer
Copy link
Member

Sorry, @killoctal, but I'm going to stick to my guns here. Let's start small as I suggested and just add support for running one suite, explicitly, using --suite <suiteName>. We can work our way up to adding more features to this new function, in small increments. It will take more back-and-forth but I think we'll be happier with the outcome, and we'll likely get higher quality feedback too.

@pjohnmeyer pjohnmeyer closed this Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants