Skip to content

Improved failure message when comparing incomparable data-types. #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 14, 2017
Merged

Improved failure message when comparing incomparable data-types. #344

merged 5 commits into from
Jun 14, 2017

Conversation

jgebal
Copy link
Member

@jgebal jgebal commented Jun 7, 2017

Fixes #334

@jgebal jgebal added the bugfix label Jun 7, 2017
@jgebal jgebal added this to the v3.0.1 milestone Jun 7, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 91.858% when pulling b317d8d on jgebal:bigfix/misleading_failure_message into f439b3d on utPLSQL:develop.

@coveralls
Copy link

coveralls commented Jun 8, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 91.708% when pulling b317d8d on jgebal:bigfix/misleading_failure_message into f439b3d on utPLSQL:develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.708% when pulling b645682 on jgebal:bigfix/misleading_failure_message into 2c5f1ef on utPLSQL:develop.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 8, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 91.708% when pulling b645682 on jgebal:bigfix/misleading_failure_message into 2c5f1ef on utPLSQL:develop.

@coveralls
Copy link

coveralls commented Jun 8, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 91.718% when pulling 24090bd on jgebal:bigfix/misleading_failure_message into 2c5f1ef on utPLSQL:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.708% when pulling a1be282 on jgebal:bigfix/misleading_failure_message into 7dcd62c on utPLSQL:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.708% when pulling a1be282 on jgebal:bigfix/misleading_failure_message into 7dcd62c on utPLSQL:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.708% when pulling a1be282 on jgebal:bigfix/misleading_failure_message into 7dcd62c on utPLSQL:develop.

@coveralls
Copy link

coveralls commented Jun 12, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 91.708% when pulling 12d933c on jgebal:bigfix/misleading_failure_message into 7dcd62c on utPLSQL:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.708% when pulling 12d933c on jgebal:bigfix/misleading_failure_message into 7dcd62c on utPLSQL:develop.

@jgebal
Copy link
Member Author

jgebal commented Jun 13, 2017

@Pazus, are you ok with this change?

@Pazus Pazus merged commit aa134be into utPLSQL:develop Jun 14, 2017
@Pazus Pazus removed the in progress label Jun 14, 2017
@jgebal jgebal deleted the bigfix/misleading_failure_message branch June 14, 2017 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pazus Pazus Pazus approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jgebal @coveralls @Pazus