-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/refactor reporter api #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReporterFactory is now a singleton. One can register its own reporters with a given name. The name is independent from the Oracle Object-Name. That way it is very easy to add a slightly different behaviour to an existing base reporter in java
Because that's very valuable information. We like valuable information. We gather them. And eat them. And grow.
Not yet finished - changes of utPLSQL/utPLSQL#589 must be implemented before |
so it works with the new core reporter objects.
clean and working with new reporter API
Made purpose of several classes more clear, updated some methods to match with core
also allow delayed instantiation of Reporters in TestRunner
…se)" This reverts commit 41ef81c
Maybe we can overcome this by an empty placeholder file. There might be a different way, but atm I don't have a clue how that could look
Tried to rearrange the order
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReporterFactory is now a singleton with the ability to register/unregister new reporters.
Therefore it's easy to inject new reporters which are then available to the factory.
Reporters which are injected should always contain a description.
Adds progress to #8
Although there should be some improvements in cli to make it easy to include custom (java-)reporters