maint ~ configuration and utility clean-up and maintenance #3090
Conversation
rivy
commented
Feb 6, 2022
- waiting for the CI to pass to make sure I didn't make any silly mistakes.
.github/workflows/GnuTests.yml
Outdated
| @@ -77,14 +77,14 @@ jobs: | |||
| run: | | |||
| ## Build binaries | |||
| cd '${{ steps.vars.outputs.path_UUTILS }}' | |||
| bash util/build-gnu.sh | |||
| bash util/build-gnu.bash | |||
There was a problem hiding this comment.
why this change?
why not making them .sh compatible instead?
There was a problem hiding this comment.
Yeah, I just jumped to the rename for shellcheck.
But I think it's just a variable expansion, so it should be reasonably simple to change.
I'll look at it from that angle and try to rework it as POSIX-shell compatible.
There was a problem hiding this comment.
Yep, dropping this rename (as unneeded) in the revision.
I must have been using an old shellcheck on a different PC; checking now shows no complaints.
|
I modified something incorrectly in the scripts supporting 'GnuTests'. 😕 |
|
I guess it is normal that it is still a draft :) |
c92b1fd to
bf192a8
Compare
|
@sylvestre , well, that was a slog trying to iterate changes and debug a process which takes 1 to 2 hours for feedback. 😅 I plan to change this to a PR in a couple of hours (when CI passes). |
|
@sylvestre , @tertsdiepraam , this is ready for comments/review. I just tweaked some commit comments which triggered another CI run, but CI is passing. |
util/build-gnu.sh
Outdated
| do | ||
| sum_path="${BUILDDIR}/${sum}" | ||
| test -f "${sum_path}" || cp "${BUILDDIR}/hashsum" "${sum_path}" | ||
| for sum in b2sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum; do |
There was a problem hiding this comment.
| for sum in b2sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum; do | |
| for sum in b2sum b3sum md5sum sha1sum sha224sum sha256sum sha384sum sha512sum; do |
41b6321 to
d76a60e
Compare
|
Added a commit fixing a Any other comments/concerns? |
|
sounds great :) |
|
and it was fixed by the initial author: #3124 |
I'll drop the fix commit and rebase off the new 'main' then... |
- combine gnu/gnulib into single repository checkout - code consolidation - DRY changes - variable consolidation and renaming - job/step naming normalization
- add more logging for better fault tracking - generalize for use in either RELEASE or DEBUG build mode (default to 'release') - improve variable naming precision/specificity
|
Done... rebased and pushed onto the fixed 'main'. |
|
excellent, thanks |
|
More conflicts on #3045 ;) |
|
I'm on it. |