cp: require preserve only certain attributes #4095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
580c42d to
71467ee
Compare
71467ee to
2f52037
Compare
|
GNU testsuite comparison: |
I have to admit this is outside my area of expertise :) If we can build a solution like this in the test framework then that would be great! |
|
@tertsdiepraam I pushed a version I made so far, code is not exactly clean, but just want to get it in the light for opinions and CI :) |
4ebc7ae to
cbaef90
Compare
9ed1a0d to
fc3b15b
Compare
fc3b15b to
50653e9
Compare
This was referenced Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GNU cp, there's a lot of special handling of errors based on using
-a,-p,--preserve=all,--preserve=xattr,contextetc. which is not handled properly at the moment. In this PR, an analogous behavior to that ofrequire_preserve_xattr,require_preserve_context, andrequire_preserveflags in GNU cp code is implemented.Somethings left todo are testing xattr permission denied case (outside of Android test), and also context permission denied case. One idea is making a simple user-space fuse FS with advanced xattr modification permission controls. I couldn't find any simple solution to this... Ideas? cc @tertsdiepraam @sylvestre
Closes #4079.