Skip to content

Update to clap 4.5.22 to fix a unsound alert on anstream #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update to clap 4.5.22 to fix a unsound alert on anstream #6924

wants to merge 1 commit into from

Conversation

sylvestre
Copy link
Contributor

Copy link

github-actions bot commented Dec 4, 2024

GNU testsuite comparison:

GNU test failed: tests/du/threshold. tests/du/threshold is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/factor. tests/factor/factor is passing on 'main'. Maybe you have to rebase?

@sylvestre sylvestre requested a review from cakebaker December 5, 2024 23:00
Copy link

github-actions bot commented Dec 5, 2024

GNU testsuite comparison:

GNU test failed: tests/du/threshold. tests/du/threshold is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/factor/factor. tests/factor/factor is passing on 'main'. Maybe you have to rebase?

@cakebaker
Copy link
Contributor

I don't know if you have seen it, but some seq tests fail.

@cakebaker
Copy link
Contributor

The problem is that there is a breaking change in clap that affects seq: see clap-rs/clap#5837 (comment)

@sylvestre
Copy link
Contributor Author

I didn't see it
I guess the gnu regressions are the same

@cakebaker
Copy link
Contributor

Closing PR, fixed in #6955

@cakebaker cakebaker closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants