printf: fix octal escape parsing #7210
Conversation
|
GNU testsuite comparison: |
|
Some jobs are failing. Could you please also add tests? :) |
where do I check which passing test has failed? I think I have a good idea why it's failing but I dont know which test it is |
|
It looks like all tests pass, though there are two jobs failing in the CI because you didn't run |
I see three failing jobs, and this one says I broke one passing test |
|
You can see the reason in an earlier comment from the bot:
It's a test that unfortunately fails from time to time. It's unrelated to your changes and so you can ignore it :) |
fixes uutils#7202 and adds a new test for the fix
|
@aryalaadi Can you resolve the conflict ? |
|
GNU testsuite comparison: |
| Self::Oct => { | ||
| if octal_0 { | ||
| 3 | ||
| } else { | ||
| 2 | ||
| } | ||
| } |
There was a problem hiding this comment.
Actually, what about we add a Base::OctZero variant to the Base enum ? It will make the code easier to understand IMO.
Also, we can get rid of the #[repr(u8)], and the = 8/= 16 values ov the Oct and Hex variants.
There was a problem hiding this comment.
sounds better, ill look into it
There was a problem hiding this comment.
sorry i have been busy, the fix is simple but i dont have access to my workstation rn, if anyone is interested feel free to append to this
|
Closing this PR as its changes have been merged with #7431 |
fixes #7202