Skip to content

Apply suggestions from clippy 0.1.87+nightly #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2025
Merged

Apply suggestions from clippy 0.1.87+nightly #7744

merged 3 commits into from
Apr 13, 2025

Conversation

BenWiederhake
Copy link
Collaborator

This applies some straight-forward suggestions from clippy-nightly. I checked each one manually, and I'm convinced this is correct.

Originally, I wanted to tackle the "unused std::ops::ControlFlow" warnings, but I'm not convinced that these are correct.

In particular:

@BenWiederhake BenWiederhake force-pushed the dev-clippy-0-1-87-nightly branch from a678e66 to e4acb7c Compare April 13, 2025 02:19
@BenWiederhake BenWiederhake force-pushed the dev-clippy-0-1-87-nightly branch from e4acb7c to 875770f Compare April 13, 2025 02:36
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@BenWiederhake
Copy link
Collaborator Author

Changes since initial push:

  • Simplify redundant closure in windows-only code
  • Remove now-unused import in windows-only code

@sylvestre sylvestre merged commit 291473e into uutils:main Apr 13, 2025
69 checks passed
@BenWiederhake BenWiederhake deleted the dev-clippy-0-1-87-nightly branch April 13, 2025 14:46
@BrewTestBot BrewTestBot mentioned this pull request May 24, 2025
Merged
@moonfruit moonfruit mentioned this pull request May 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWiederhake @sylvestre