Skip to content

chore: remove unused dependencies #8056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

chore: remove unused dependencies #8056

wants to merge 14 commits into from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Jun 3, 2025

Try to remove all unused dependencies from various crates

@nyurik nyurik marked this pull request as draft June 3, 2025 19:47
@nyurik nyurik force-pushed the udeps branch 4 times, most recently from d59d331 to db851d4 Compare June 3, 2025 20:19
Copy link

github-actions bot commented Jun 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

* properly add all crates to the workspace cargo.toml as members
  * except `fuzz` because it still has some issues, TBD
* use quotes around `true` and `false` to ensure there is no bool confusion
* remove a few leftover readme comments
* mark all unpublishable crates as `publish = false` to avoid accidental publishing
* Add `uutests` to the main workspace
nyurik added 2 commits June 3, 2025 18:20
Try to remove all unused dependencies from various crates
Copy link

github-actions bot commented Jun 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

Copy link

github-actions bot commented Jun 4, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

i am confused. Seems some duplicate on #8058 ?

@nyurik
Copy link
Contributor Author

nyurik commented Jun 4, 2025

@sylvestre no, this WIP contains 8058, but it also removes a lot of unneeded dependencies - but lets only merge this after 8058 lands

@cakebaker
Copy link
Contributor

Fyi, you are adding some very old stuff, like clap 2.x.

@nyurik
Copy link
Contributor Author

nyurik commented Jun 4, 2025

@cakebaker not sure where you saw this

@cakebaker
Copy link
Contributor

@nyurik in Cargo.lock

@nyurik
Copy link
Contributor Author

nyurik commented Jun 4, 2025

ah, yes - well, that dependency is a dev dependency by a crate which was not part of the workspace -- all these changes are in #8058. Having it in a workspace would raise awareness of that crate, and will allow us to update all of its dependencies - rather than uu_factor_benches accidentally being forgotten and not reviewed.

❯ cargo tree --workspace -i clap@2
clap v2.34.0
└── criterion v0.3.6
    [dev-dependencies]
    └── uu_factor_benches v0.0.0 (/home/nyurik/dev/rust/coreutils/tests/benches/factor)

nyurik added 4 commits June 4, 2025 05:39
* properly add all crates to the workspace cargo.toml as members
  * except `fuzz` because it still has some issues, TBD
* use quotes around `true` and `false` to ensure there is no bool confusion
* remove a few leftover readme comments
* mark all unpublishable crates as `publish = false` to avoid accidental publishing
* Add `uutests` to the main workspace
* Update very old dependencies of the `tests/benches/factor`
Copy link

github-actions bot commented Jun 4, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

needs rebasing now :)

Copy link

github-actions bot commented Jun 6, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants