-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore: remove unused dependencies #8056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d59d331
to
db851d4
Compare
GNU testsuite comparison:
|
* properly add all crates to the workspace cargo.toml as members * except `fuzz` because it still has some issues, TBD * use quotes around `true` and `false` to ensure there is no bool confusion * remove a few leftover readme comments * mark all unpublishable crates as `publish = false` to avoid accidental publishing * Add `uutests` to the main workspace
Try to remove all unused dependencies from various crates
GNU testsuite comparison:
|
GNU testsuite comparison:
|
i am confused. Seems some duplicate on #8058 ? |
@sylvestre no, this WIP contains 8058, but it also removes a lot of unneeded dependencies - but lets only merge this after 8058 lands |
Fyi, you are adding some very old stuff, like |
@cakebaker not sure where you saw this |
@nyurik in |
ah, yes - well, that dependency is a dev dependency by a crate which was not part of the workspace -- all these changes are in #8058. Having it in a workspace would raise awareness of that crate, and will allow us to update all of its dependencies - rather than
|
* properly add all crates to the workspace cargo.toml as members * except `fuzz` because it still has some issues, TBD * use quotes around `true` and `false` to ensure there is no bool confusion * remove a few leftover readme comments * mark all unpublishable crates as `publish = false` to avoid accidental publishing * Add `uutests` to the main workspace * Update very old dependencies of the `tests/benches/factor`
GNU testsuite comparison:
|
needs rebasing now :) |
GNU testsuite comparison:
|
Try to remove all unused dependencies from various crates