Skip to content

chore: remove unused dependencies #8056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: remove unused dependencies #8056

wants to merge 1 commit into from

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Jun 3, 2025

Try to remove all unused dependencies from various crates

@nyurik nyurik marked this pull request as draft June 3, 2025 19:47
@nyurik nyurik force-pushed the udeps branch 4 times, most recently from d59d331 to db851d4 Compare June 3, 2025 20:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@nyurik nyurik force-pushed the udeps branch 2 times, most recently from 2bcbd4b to d5dfcfe Compare June 3, 2025 22:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

i am confused. Seems some duplicate on #8058 ?

@nyurik
Copy link
Contributor Author

nyurik commented Jun 4, 2025

@sylvestre no, this WIP contains 8058, but it also removes a lot of unneeded dependencies - but lets only merge this after 8058 lands

@cakebaker
Copy link
Contributor

Fyi, you are adding some very old stuff, like clap 2.x.

@nyurik
Copy link
Contributor Author

nyurik commented Jun 4, 2025

@cakebaker not sure where you saw this

@cakebaker
Copy link
Contributor

@nyurik in Cargo.lock

@nyurik
Copy link
Contributor Author

nyurik commented Jun 4, 2025 •
edited
Loading

ah, yes - well, that dependency is a dev dependency by a crate which was not part of the workspace -- all these changes are in #8058. Having it in a workspace would raise awareness of that crate, and will allow us to update all of its dependencies - rather than uu_factor_benches accidentally being forgotten and not reviewed.

❯ cargo tree --workspace -i clap@2
clap v2.34.0
└── criterion v0.3.6
    [dev-dependencies]
    └── uu_factor_benches v0.0.0 (/home/nyurik/dev/rust/coreutils/tests/benches/factor)

@nyurik nyurik mentioned this pull request Jun 4, 2025
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)

@sylvestre
Copy link
Contributor

needs rebasing now :)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@nyurik nyurik force-pushed the udeps branch 4 times, most recently from b70a1e9 to 79475bc Compare July 2, 2025 23:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/stdbuf (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@nyurik nyurik marked this pull request as ready for review July 3, 2025 00:42
@nyurik
Copy link
Contributor Author

nyurik commented Jul 3, 2025

ok, this seemed to have finally passed all tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nyurik @sylvestre @cakebaker