Skip to content

Replace the regex parser with winnow-based parse #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Replace the regex parser with winnow-based parse #137

wants to merge 4 commits into from

Conversation

yuankunzhang
Copy link

Revamp of #86.

@yuankunzhang yuankunzhang marked this pull request as draft May 1, 2025 13:06
@yuankunzhang yuankunzhang force-pushed the replace-the-regex-parser branch 3 times, most recently from 1fbb6ec to befe2ec Compare May 1, 2025 13:19
@yuankunzhang yuankunzhang marked this pull request as ready for review May 1, 2025 13:20
@yuankunzhang yuankunzhang force-pushed the replace-the-regex-parser branch from befe2ec to bd8b226 Compare May 1, 2025 14:40
tertsdiepraam
tertsdiepraam reviewed May 1, 2025
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot! I've just reviewed your changes for now and I'll try to get a full review done soon. We could also just merge this and fix issues later as I think at least the structure is good.

src/lib.rs
Comment on lines +539 to +543
"1997-01-01 00:00:00.000000000 1 year",
"Wed Jan 1 00:00:00 1997 1 year",
"1997-01-01T00:00:00 1 year",
"1997-01-01 00:00:00 1 year",
"1997-01-01 00:00 1 year",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the formats that were here not be supported? Should we test for both?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those formats render as invalid dates in GNU date, so I removed them.

@yuankunzhang yuankunzhang force-pushed the replace-the-regex-parser branch from bd8b226 to 398ed93 Compare May 2, 2025 12:42
@yuankunzhang yuankunzhang mentioned this pull request May 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuankunzhang @tertsdiepraam @dhilst