Add TZ="timezone" support #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please run |
|
@yuankunzhang I have seen you started with the migration from |
|
It is better for this PR to wait until the |
|
Hi @bezmuth , now that we have completed the chrono to jiff migration, could you please refactor your code based on the latest main branch? Thanks. |
|
Yep, I'll get on it. Jiff seems a lot more robust for timezones |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: uutils/coreutils#7520
This is my first pr to the uutils repos so there is a good chance I've made a few mistakes, I'm not entirely sure if I've chosen the right name for functions/variables either. I can write some tests for the TZ= functionality but I want to make sure I haven't missed anything yet.